BB2-2660: Move logic from save to clean for oauth client and grant type #1210
+27
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-2660
User Story or Bug Summary:
This is a continuation of work done in #1203. There was some discussion during that PR about where some logic should go, but we ended up not making a change because we couldn't get that working. We've since delivered that PR, but this PR covers those adjustments.
What Does This PR Do?
This PR moves all of the logic for the hardcoding of the oauth settings into the clean function instead of the save function. It also reintroduces some unit tests, but where before they would verify that the form is invalid, they now verify that regardless of input, the resulting cleaned data is the same. It may be useful to compare the new form of those tests with what was there before #1203.
What Should Reviewers Watch For?
All of the same things that were relevant in #1203 are still relevant. We should make sure there is no regression by testing adding/editing apps locally.
What Security Implications Does This PR Have?
None.
Submitters should complete the following questionnaire:
What Needs to Be Merged and Deployed Before this PR?
None
Any Migrations?
None
Submitter Checklist
I have gone through and verified that...:
README
updates and changelog / release notes entries.TODO
and/orFIXME
comments, which include a JIRA ticket ID for any items that require urgent attention.