Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-186: Debugging #18

Merged
merged 41 commits into from
Dec 8, 2023
Merged

PLT-186: Debugging #18

merged 41 commits into from
Dec 8, 2023

Conversation

gfreeman-navapbc
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/PLT-186

🛠 Changes

This PR contains fixes for the original implementation of the runner build workflow.

ℹ️ Context for reviewers

In order to test workflows, we must first merge them into the repo.

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@gsf
Copy link
Member

gsf commented Nov 2, 2023

If you add this to your workflow file then GitHub will run it on each push, which is handy. (I did the same thing in https://github.com/CMSgov/ab2d-bcda-dpc-platform/pull/17/files#diff-67237c8e8d172516ba6771e48d67e8167dae05abbd9bc286dc90524c4c4ad754R6):

on:
  pull_request:
    paths:
      - .github/workflows/build-runner-images.yml
      - packer/github-actions-runner/**

@gfreeman-navapbc gfreeman-navapbc marked this pull request as ready for review December 7, 2023 18:20
@gfreeman-navapbc gfreeman-navapbc requested a review from a team as a code owner December 7, 2023 18:20
"Name=tag:Layer,Values=app" \
--query 'Subnets[0].SubnetId' \
--output text)
echo "SUBNET_ID=$SUBNET_ID" >> "$GITHUB_ENV"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to do this with data sources in the hcl file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it doesn't seem that way, Terraform includes the datasources for aws_vpc and aws_subnet, but those are mysteriously left out of the packer data sources documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, another weird quirk of Packer! Thanks for checking.

@gfreeman-navapbc gfreeman-navapbc merged commit a22c1c7 into main Dec 8, 2023
1 check passed
@gfreeman-navapbc gfreeman-navapbc deleted the gfreeman_PLT-186_fixes branch December 8, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants