-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-503: Add test and sandbox environments to DPC WAF plan and apply #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what impact our engineers should actually see with this - seems like this is just setting up the skeleton for rules to be capable of being applied, but isn't actually applying rules? I haven't followed this all the way back to the current WAF configuration to verify that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The api-waf service will need to be updated to not create and associate IP sets on sandbox.
See https://github.com/CMSgov/ab2d-bcda-dpc-platform/tree/main/terraform/modules/firewall |
🎫 Ticket
https://jira.cms.gov/browse/PLT-503
🛠 Changes
Adds test and sbx environments to the DPC WAF configuration
ℹ️ Context
These are changes made as a part of the overall WAF migration work.
🧪 Validation
Once this is applied, we should see the Web ACL configurations show up with the placeholder IP sets. We'll need to manually update them in AWS, and then reapply once we remove the association with the security group on ingress.