Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac OS X cleaning #8536

Merged
merged 2 commits into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ Scripts/developer_scripts/check_svn_keywords text eol=lf
Scripts/developer_scripts/create_cgal_test text eol=lf
Scripts/developer_scripts/create_cgal_test_with_cmake text eol=lf
Scripts/developer_scripts/create_internal_release text eol=lf
Scripts/developer_scripts/create_macosx_installer text eol=lf
Scripts/developer_scripts/create_new_release text eol=lf
Scripts/developer_scripts/detect_files_with_mixed_eol_styles text eol=lf
Scripts/developer_scripts/detect_packages_licenses text eol=lf
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -1058,7 +1058,7 @@ cmake_install.cmake
*~
.#*

# MacOS file https://en.wikipedia.org/wiki/.DS_Store
# macOS file https://en.wikipedia.org/wiki/.DS_Store
.DS_Store

# Binaries:
Expand Down
2 changes: 1 addition & 1 deletion Documentation/doc/Documentation/Third_party.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ supporting C++17 or later.
| | `Clang` \cgalFootnote{<A HREF="https://clang.llvm.org/">\cgalFootnoteCode{https://clang.llvm.org/}</A>} compiler version 15.0.7 |
| \ms Windows | \gnu `g++` 11.4.0 or later\cgalFootnote{<A HREF="https://gcc.gnu.org/">\cgalFootnoteCode{https://gcc.gnu.org/}</A>} |
| | \ms Visual `C++` 15.9, 16.10, 17.0 (\visualstudio 2017, 2019, and 2022)\cgalFootnote{<A HREF="https://visualstudio.microsoft.com/">\cgalFootnoteCode{https://visualstudio.microsoft.com/}</A>} |
| MacOS X | \gnu `g++` 11.4.0 or later\cgalFootnote{<A HREF="https://gcc.gnu.org/">\cgalFootnoteCode{https://gcc.gnu.org/}</A>} |
| macOS | \gnu `g++` 11.4.0 or later\cgalFootnote{<A HREF="https://gcc.gnu.org/">\cgalFootnoteCode{https://gcc.gnu.org/}</A>} |
| | Apple `Clang` compiler versions 10.0.1, 12.0.5, and 15.0.0 |

<!-- Windows supported version are also listed on windows.html (must change both) -->
Expand Down
4 changes: 1 addition & 3 deletions Installation/cmake/modules/FindCORE.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
# CORE_INCLUDE_DIR - the CORE include directory
# CORE_LIBRARIES - Libraries needed to use CORE

# TODO: support Windows and MacOSX

# CORE needs GMP
include(FindPackageHandleStandardArgs)

Expand All @@ -17,7 +15,7 @@ if(GMP_FOUND)
find_path(CORE_INCLUDE_DIR NAMES CORE.h DOC "The directory containing the CORE include files")

find_library(CORE_LIBRARIES NAMES core++ DOC "Path to the core++ library")

get_filename_component(CORE_LIBRARIES_DIR ${CORE_LIBRARIES} PATH)

FIND_PACKAGE_HANDLE_STANDARD_ARGS(CORE "DEFAULT_MSG" CORE_LIBRARIES CORE_INCLUDE_DIR )
Expand Down
2 changes: 0 additions & 2 deletions Installation/cmake/modules/FindGMP.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
# GMP_LIBRARIES_DIR - directory where the GMP libraries are located
# GMP_LIBRARIES - Link these to use GMP

# TODO: support MacOSX

include(FindPackageHandleStandardArgs)
include(${CMAKE_CURRENT_LIST_DIR}/CGAL_GeneratorSpecificSettings.cmake)

Expand Down
2 changes: 0 additions & 2 deletions Installation/cmake/modules/FindGMPXX.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
# GMPXX_INCLUDE_DIR - the GMPXX include directory
# GMPXX_LIBRARIES - Libraries needed to use GMPXX

# TODO: support Windows and MacOSX

# GMPXX needs GMP

find_package( GMP QUIET )
Expand Down
2 changes: 0 additions & 2 deletions Installation/cmake/modules/FindMPFR.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
# MPFR_LIBRARIES_DIR - Directory where the MPFR libraries are located
# MPFR_LIBRARIES - the MPFR libraries

# TODO: support MacOSX

include(FindPackageHandleStandardArgs)
include(${CMAKE_CURRENT_LIST_DIR}/CGAL_GeneratorSpecificSettings.cmake)

Expand Down
14 changes: 0 additions & 14 deletions Installation/include/CGAL/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -243,20 +243,6 @@
# define CGAL_SUNPRO_INITIALIZE(C)
#endif

//----------------------------------------------------------------------//
// MacOSX specific.
//----------------------------------------------------------------------//

#ifdef __APPLE__
# if defined(__GNUG__) && (__GNUG__ == 4) && (__GNUC_MINOR__ == 0) \
&& defined(__OPTIMIZE__) && !defined(CGAL_NO_WARNING_FOR_MACOSX_GCC_4_0_BUG)
# warning "Your configuration may exhibit run-time errors in CGAL code"
# warning "This appears with g++ 4.0 on MacOSX when optimizing"
# warning "You can disable this warning using -DCGAL_NO_WARNING_FOR_MACOSX_GCC_4_0_BUG"
# warning "For more information, see https://www.cgal.org/FAQ.html#mac_optimization_bug"
# endif
#endif

//-------------------------------------------------------------------//
// When the global min and max are no longer defined (as macros)
// because of NOMINMAX flag definition, we define our own global
Expand Down
Binary file removed MacOSX/auxiliary/cgal_app.icns
Binary file not shown.
1 change: 0 additions & 1 deletion MacOSX/package_info/MacOSX/copyright

This file was deleted.

3 changes: 0 additions & 3 deletions MacOSX/package_info/MacOSX/description.txt

This file was deleted.

1 change: 0 additions & 1 deletion MacOSX/package_info/MacOSX/maintainer

This file was deleted.

102 changes: 0 additions & 102 deletions MacOSX/scripts/cgal_make_macosx_app

This file was deleted.

2 changes: 1 addition & 1 deletion Profiling_tools/include/CGAL/Memory_sizer.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include <CGAL/config.h>
#include <CGAL/assertions.h>

// This has only been implemented for MacOSX/Darwin, Linux and VC++ for now.
// This has only been implemented for macOS/Darwin, Linux and VC++ for now.
#if !defined _MSC_VER && !defined __linux__ && !defined __APPLE__

#include <iostream>
Expand Down
1 change: 0 additions & 1 deletion REUSE.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ path = [
"Installation/auxiliary/cgal_create_cmake_script.1",
"Installation/auxiliary/gmp/README",
"Installation/include/CGAL/license/gpl_package_list.txt",
"MacOSX/auxiliary/cgal_app.icns",
"copyright",
]
precedence = "aggregate"
Expand Down
78 changes: 0 additions & 78 deletions Scripts/developer_scripts/create_macosx_installer

This file was deleted.

1 change: 0 additions & 1 deletion copyright
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ R = RU Groningen
LEDA ETIMU
Largest_empty_rect_2 T
Linear_cell_complex CNRS
MacOSX F
Maintenance ETIMUG
Manual ETIMU
Manual_tools EIM, Modena Software, Silicon Graphics
Expand Down