-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CGAL: Modernize CMakeLists.txt #8528
base: master
Are you sure you want to change the base?
Conversation
I guess we have a test platform where we use the "minimal required" version of cmake? Also can we then remove the line |
It is needed. Does that need "modernization" @lrineau ? |
My guess is that it will depend how boost is found (config mode or with FindBoost.cmake).
IIRC, this is to disable something at runtime in the example. So if you remove it you need to update the example and the cmake script to not compile it. |
…where, but let's first see a green testsuite
No. That preprocessor macro is used in |
cgal/Ridges_3/examples/Ridges_3/CMakeLists.txt Lines 21 to 30 in 4305f01
It swaps three lines of |
TBB seems also to use keywords like
Maybe we can tell |
Bless the CI! And I thanks myself for that initiative (started by #4234). |
There is a disussion on github/TBB. There I even saw @mglisse. |
42a4178
to
9e75ab3
Compare
Starting cmake 3.5, |
That is the CMake support for the function |
[skip ci] (wait for the second batch of modifications)
324b45c
to
2ca1c4e
Compare
Point_set_processing_3/examples/Point_set_processing_3/CMakeLists.txt
Outdated
Show resolved
Hide resolved
/build:doc |
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8528/doc/Manual/index.html |
I have reviewed all modifications. It should be the last batch.
Summary of Changes
PUBLIC
toPRIVATE
in thetarget_link_libraries()
Link againstas we do more than just linking and must use theBoost::<COMPONENT>
CGAL::_.._support
target_compile_definitions()
andadd_compile_definitions()
More to be done.
Release Management