Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double use of citation name #8504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

albert-github
Copy link
Contributor

Based on #8320 and doxygen/doxygen#11157 creating an assertion for builds from scratch when a citation name is used multiple times.

Based on CGAL#8320 and doxygen/doxygen#11157 creating an assertion for builds from scratch when a citation name is used multiple times.
(doxygen cannot catch these here as they are directly written into html code).
@afabri
Copy link
Member

afabri commented Sep 30, 2024

It would be good to add a duplicate entry so that we can see that it gets catched in the manual testsuite.

@albert-github
Copy link
Contributor Author

Well that would probably be a bit problematic as it has to be in PackageDescription.txt files and we would see it every night in the overview https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/
Or are you referring to another place?

@afabri
Copy link
Member

afabri commented Sep 30, 2024

You added a duplicate detection feature to a script that is run to build the full documentation.
In order to test your feature we should add a duplicate, and merge this branch in integration.
If your feature works we will see it in the documentation testsuite page.
Then we can remove the duplicate again, and merge this PR in master.

@albert-github
Copy link
Contributor Author

albert-github commented Sep 30, 2024

That would be one scenario. Another would be to do it locally, like I did for testing.
I changed the original problematic ones (#8318), i.e. the ones in

  • Kinetic_space_partition/doc/Kinetic_space_partition/PackageDescription.txt
  • Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/PackageDescription.txt

to cgal:ol-kinetic and ran the documentation generation locally so that I got the error.
In my opinion no need to create 2 extra commits (there are enough commits in CGAL already ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants