-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lab - add polylines to selection of edges #8411
base: master
Are you sure you want to change the base?
Lab - add polylines to selection of edges #8411
Conversation
@@ -1680,7 +1680,7 @@ void | |||
remove_patches(TriangleMesh& tm, | |||
const boost::dynamic_bitset<>& patches_to_remove, | |||
PatchContainer& patches, | |||
const EdgeMarkMap& edge_mark_map) | |||
EdgeMarkMap& edge_mark_map) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change leads to a failure in the CI
0d1ecbe
to
95be09a
Compare
I guess the warning in I-c-351 comes from this PR. @janetournois can you check if the plugin does what you want to achieve. |
|
||
auto locate_vertex = [&](const Point_3& p)->vertex_descriptor | ||
{ | ||
const double tol = 1e-5; //todo : make tolerance depend on bbox size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: unused variable
one clip case is not correctly handled yet
…nd constrain_intersection_edges
Summary of Changes
With this PR
Release Management