MySQL queries - forward slashes in bindings #14855
Merged
+128
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empting to make this less all catching. Likely an area of concern, but there is currently no way to search for dates without this.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Had a look at this one - for queries there is a coercion of strings if they are dates - we have test cases covering this in
generic-sql.ts, without the coercion dates cannot be worked with.Ideally we would allow specification of the type the binding should assume, as right now it is always a string - but for now making the coercion a bit less over-arching.
Previously it didn't specify any formats, therefore anything that faintly looked like a date would get parsed, now there's only a set of a few formats which we support (also checks validity of the days/months/years).
Addresses: