"Create screen" component context option #14255
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aptkingston
reviewed
Sep 19, 2024
| candidateUrl = makeCandidateUrl(screen, ++suffix) | ||
| let candidateUrl = screenStore.makeCandidateUrl(screen, suffix) | ||
| while (screenStore.hasExistingUrl(candidateUrl, screenAccessRole)) { | ||
| candidateUrl = screenStore.makeCandidateUrl(screen, ++suffix) |
There was a problem hiding this comment.
Rather than all this logic (some of which I know was pre-existing), we should use our getSequentialName utility which is designed to do exactly this!
| globalContext.actions.clearComponentContext() | ||
| } | ||
|
|
||
| $: purgeGlobalComponentContext($screenStore?.activeScreen?._id) |
There was a problem hiding this comment.
I understand the purpose of this, but I think we should come up with a cleaner way of handling it than trying to whitelist all properties that we want to persist between screen changes. I have a few ideas in mind... For now I think it would be better to take this out of this PR as it's a separate issue, and we can tackle it elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A
Create screenoption has been added to the component context menu in the builder. Selecting the option will:Basicrole/new-screen. If you create multiple screens in a row a suffix will be appended to avoid collision e.g./new-screen-2Addresses
Fix- component context options were being cached between screens. When pasting or cloning into new screens, it wasn't immediately clear what elements had become broken due to broken context references until full page refresh. The component options will now clear when the active screen is changed.Screenshots
Launchcontrol
Create a new screen from a selected component