Fix datasource deletion (when selected) causing builder crash #12091
Conversation
…o an empty object it appeared like a datasource had been set and the UI would attempt to render with this empty state. When not selected move off of the selected datasource page instead and handle the datasource not being selected.
| $: { | ||
| if (!datasource) { | ||
| $goto("./datasource") | ||
| } | ||
| } |
There was a problem hiding this comment.
Ooh I didn't know you could do this! I assumed reactive statements had to be variable assignments. Cool!
There was a problem hiding this comment.
You can indeed! You can have any arbitrary code inside a reactive statement like this, and svelte will re-run it when any of the variables used inside the statement change. What svelte determines a "change" worth invalidating reactive statements is either a reassignment (if a normal JS variable) or a store value change (if using a svelte store).
There was a problem hiding this comment.
The even cleaner way to fix this is simply wrap a guard around the slot inside [datasourceId]/_layout.svelte which ensures that we won't ever render a datasource details route without having one selected in state.
A quick test locally confirms that this does fix it (and is more in line with what we do elsewhere):
...
{#if $datasources.selected}
<slot />
{/if}
...We can also remove the fallback code of
// datasources.selected can return null temporarily on datasource deletion
$: datasource = $datasources.selected || {}since that isn't needed either with this change.
Description
Quick fix for datasource deletion, due to the datasource defaulting to an empty object it appeared like a datasource had been set and the UI would attempt to render with this empty state. When not selected move off of the selected datasource page instead and handle the datasource not being selected.
Addresses: https://linear.app/budibase/issue/BUDI-7630/error-in-console-when-deleting-a-datasource-navigation-then-breaks
Feature branch env
Feature Branch Link