Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff for linter and formatting #508

Closed
wants to merge 12 commits into from
Closed

Conversation

BradyAJohnston
Copy link
Owner

  • cleanup code with ruff
  • add ruff GHA
  • some cleanup
  • fix some problems
  • fix lint problems

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 64.39716% with 251 lines in your changes missing coverage. Please review.

Project coverage is 74.99%. Comparing base (e18b144) to head (a5853c2).
Report is 35 commits behind head on main.

Current head a5853c2 differs from pull request most recent head 3f2ade8

Please upload reports for the commit 3f2ade8 to get more accurate results.

Files Patch % Lines
molecularnodes/utils.py 30.00% 28 Missing ⚠️
molecularnodes/pkg.py 34.28% 23 Missing ⚠️
molecularnodes/ui/node_menu.py 47.72% 23 Missing ⚠️
molecularnodes/io/md.py 16.00% 21 Missing ⚠️
molecularnodes/ui/panel.py 34.48% 19 Missing ⚠️
molecularnodes/io/parse/cif.py 36.00% 16 Missing ⚠️
molecularnodes/io/wwpdb.py 38.09% 13 Missing ⚠️
molecularnodes/io/local.py 20.00% 12 Missing ⚠️
molecularnodes/ui/func.py 14.28% 12 Missing ⚠️
molecularnodes/blender/bones.py 33.33% 10 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   75.70%   74.99%   -0.72%     
==========================================
  Files          41       41              
  Lines        3742     3783      +41     
==========================================
+ Hits         2833     2837       +4     
- Misses        909      946      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyAJohnston BradyAJohnston added this to the 4.2 milestone Jun 5, 2024
@BradyAJohnston
Copy link
Owner Author

Ruff already implemented, will formalise in a newer cleaner PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant