Replace ChillDKG seed with hostseckey #42
Conversation
There was a problem hiding this comment.
Concept ACK for the reasons explained in #28.
perhaps the seed argument in encpedpop participant_step1 should then also be renamed to deckey (because that's what we pass anyway)
WIP because the markdown is inconsistent and confusing. For example, the "host
secret key" is also called "long-term secret key", "host secret key", "device
secret key" or just "secret key".
Urghs yeah. What about calling it "host secret key" always, but adding descriptive prefixes if necessary? See my inline suggestions.
| @@ -124,44 +125,34 @@ def certeq_coordinator_step(sigs: List[bytes]) -> bytes: | |||
| ### | |||
|
|
|||
|
|
|||
| def hostseckey(seed: bytes) -> bytes: | |||
| return prf(seed, "chilldkg hostseckey") | |||
| def hostpubkey_gen(hostseckey: bytes) -> bytes: | |||
There was a problem hiding this comment.
| def hostpubkey_gen(hostseckey: bytes) -> bytes: | |
| def hostpubkey(hostseckey: bytes) -> bytes: |
I like this a bit more.
- I don't think the public key is "generated" at this point. It's rather that the entire key pair is generated when the hostseckey is created.
- For consistency with the other names. We also don't use
certeq_message_genorparams_id_gen.
There was a problem hiding this comment.
The name was chosen to be consistent with BIP 340's def pubkey_gen(seckey: bytes) -> bytes. But I agree with your reasoning.
There was a problem hiding this comment.
done. I renamed the local conflicting variables to hostpk.
There was a problem hiding this comment.
Oh, I missed the local conflict. That's pretty ugly, to be honest.
Well, let me just merge this. Perhaps I'll suggest a more elegant variant later if I find one.
|
|
Forgot to push your changes? ;) |
jonasnick
force-pushed
the
replace-seed
branch
from
226718e
to
11b4059
Compare
real-or-random
changed the title
|
I reverted the naming change. (I think I had a point there, but I really dislike the naming conflict with the local variables...) Manually pushed to master here as 4617da4 |
ChillDKG anyway passes the hostseckey for both, so this was potentially confusing to readers of the code. This change is in line with BlockstreamResearch#42.
WIP because the markdown is inconsistent and confusing. For example, the "host secret key" is also called "long-term secret key", "host secret key", "device secret key" or just "secret key".
Fixes #28