[GAC-43] Disable implementation for ODBC API #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define macro for unsupported ODBC API * When an unimplemented ODBC API is called, a log would be generated as warning. This will help debug process and let us know which unimplemented API has been called. Disable ODBC APIs at entry level * Use `ifdef` to disable code at entry level. The disabled code should be replaced with calls to Dremio's `flightsql-odbc` classes in later PRs. * Disable header includes for Timestream-specific classes
Ubuntu 20.04 Debug Build Test Results Check
|
Windows 2022 (x64) Debug Build Code Coverage Test Results Check
|
MacOS Big Sur 11 Debug Build Code Coverage Unit and Integration Test Result
|
affonsov
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Disable exisiting ODBC API implementation, so it can be replaced by a different client.
What changes are included in this PR?
Define macro for unsupported ODBC API
Disable ODBC APIs at entry level
ifdefto disable code at entry level. The disabled code should be replaced with calls to Dremio'sflightsql-odbcclasses in later PRs.Are these changes tested?
Minimal manual testing has been done. The driver can still build successfully.
As we develop more ODBC APIs, we will add integration tests for them.
Are there any user-facing changes?
No.