Remove subscription parameter #364
Open
+5
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on removing the
subscriptionparameter from various YAML configuration files and updating the way subscription IDs are handled. The most important changes include the removal of thesubscriptionparameter from job and step templates, and the introduction ofAZURE_SUBSCRIPTION_IDas a variable in the pipeline stages.Removal of
subscriptionparameter:jobs/competitive-test.yml: Removed thesubscriptionparameter from theparameterssection and all job templates. [1] [2] [3] [4]steps/cloud/azure/upload-storage-account.yml: Removed thesubscriptionparameter from theparameterssection and related conditional steps.steps/provision-resources.yml: Removed thesubscriptionparameter from theparameterssection and related conditional steps. [1] [2] [3]steps/publish-results.yml: Removed thesubscriptionparameter from theparameterssection and related conditional steps. [1] [2]steps/setup-tests.yml: Removed thesubscriptionparameter from theparameterssection and related conditional steps. [1] [2]steps/terraform/run-command.yml: Removed thesubscriptionparameter from theparameterssection and updated the environment variable to use$(AZURE_SUBSCRIPTION_ID). [1] [2]Introduction of
AZURE_SUBSCRIPTION_IDvariable:pipelines/perf-eval/apiserver-benchmark-virtualnodes100-pods10k.yml: AddedAZURE_SUBSCRIPTION_IDas a variable in the stages and removed thesubscriptionparameter from job templates. [1] [2]