Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add traffic manager backend controller to handle delete #203

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhiying-lin
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@zhiying-lin zhiying-lin marked this pull request as draft October 13, 2024 06:13
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 45.65217% with 100 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (db04dcd) to head (c9ae512).

Files with missing lines Patch % Lines
...ontrollers/hub/trafficmanagerbackend/controller.go 44.94% 83 Missing and 15 partials ⚠️
...ontrollers/hub/trafficmanagerprofile/controller.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   79.66%   77.65%   -2.01%     
==========================================
  Files          26       27       +1     
  Lines        2493     3424     +931     
==========================================
+ Hits         1986     2659     +673     
- Misses        370      613     +243     
- Partials      137      152      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiying-lin zhiying-lin marked this pull request as ready for review October 23, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant