Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARC cluster types for workload identity #918

Closed
wants to merge 8 commits into from

Conversation

anagg929
Copy link

@anagg929 anagg929 commented May 1, 2023

Reason for Change:

This is the PR for supporting Workload identity in ARC cluster types. In ARC cluster types we are expecting the identity from a separate identity provider which are creating and maintaining secrets. The mutating web-hook is expected to mount a secret in this case.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@codecov-commenter
Copy link

Codecov Report

Merging #918 (13fb315) into main (ba4a63e) will increase coverage by 2.34%.
The diff coverage is 68.62%.

@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
+ Coverage   51.76%   54.10%   +2.34%     
==========================================
  Files          36       36              
  Lines        2376     2336      -40     
==========================================
+ Hits         1230     1264      +34     
+ Misses       1100     1023      -77     
- Partials       46       49       +3     
Impacted Files Coverage Δ
pkg/webhook/webhook.go 78.59% <68.62%> (-0.70%) ⬇️

... and 5 files with indirect coverage changes

@aramase
Copy link
Member

aramase commented Jul 24, 2023

Closing this PR as it's inactive and there are ongoing internal discussions.

@aramase aramase closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants