Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update authority url in confidential client #1436

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented Aug 14, 2024

According to the function signature

// New is the constructor for Client. authority is the URL of a token authority such as "https://login.microsoftonline.com/<your tenant>".
// If the Client will connect directly to AD FS, use "adfs" for the tenant. clientID is the application's client ID (also called its
// "application ID").
func New(authority, clientID string, cred Credential, options ...Option) (Client, error) {

xref: https://github.com/AzureAD/microsoft-authentication-library-for-go/blob/v1.2.2/apps/confidential/confidential.go#L310-L313

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/c/fix_msal_go_example branch from 90f8890 to 21bf859 Compare August 14, 2024 00:12
@aramase aramase marked this pull request as ready for review August 14, 2024 00:29
@aramase aramase requested a review from enj as a code owner August 14, 2024 00:29
@aramase aramase merged commit 6fbc034 into Azure:main Aug 14, 2024
21 checks passed
@aramase aramase deleted the aramase/c/fix_msal_go_example branch August 14, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants