Set Dev Version Fix #38089
Merged
Set Dev Version Fix #38089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
commented
Oct 24, 2024
| @@ -69,7 +69,7 @@ def get_packages( | |||
| paths = get_setup_py_paths(args.glob_string, target_dir, additional_excludes) | |||
|
|
|||
| # Check if package is excluded if a package name param is passed | |||
| if package_name and not any(filter(lambda x: package_name == os.path.basename(os.path.dirname(x)), paths)): | |||
There was a problem hiding this comment.
paths is populated by discover_targeted_packages, which changed to return the directory of the package, not the exact path to the setup.py. As a result, os.path.dirname(x) became unnecessary and in fact broke the targeting by name.
JimSuplizio
approved these changes
Oct 24, 2024
Thanks for the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke the
SetTestPipelinewhere we target a specific package with my merge ofpyproject.toml.