[evaluation] fix: Remove "complex" type hints for AsyncEvaluators #37964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
ninghu
approved these changes
Oct 17, 2024
|
API change check API changes are not detected in this pull request. |
nagkumar91
approved these changes
Oct 22, 2024
This introduced a regression where promptflow rejected the evaluators
because they were of types promptflow doesn't support.
kdestin
force-pushed
the
evaluation/mypy/remove-evaluator-type-hints
branch
from
289343e
to
1b3bd98
Compare
kdestin
force-pushed
the
evaluation/mypy/remove-evaluator-type-hints
branch
from
1b3bd98
to
de38ee8
Compare
needuv
approved these changes
Oct 22, 2024
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves a regression introduced by #37615 that causes evaluation to fail because promptflow rejects evaluators with "complex" type hints.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines