Fix workflow for building 'OSConfig for MC' on Ubuntu 14.04 #777
Conversation
Our src/CMakeLists.txt specifies this: cmake_minimum_required(VERSION 3.2) The Ubuntu 14.04 package "cmake" install cmake 2.8, so switch to cmake3 which installs cmake 3.5. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
'OSConfig for MC' is built on Ubuntu 14.04 so that the resulting artifact is portable across supported distros. Ubuntu 14.04 comes with CMake 3.5, which doesn't support `--parallel`. 'OSConfig for MC' is small so we can afford to not build in parallel. An alternative is to directly invoke `make -jX`. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
@MariusNi, @AhmedBM: this PR fixes this failure: https://github.com/Azure/azure-osconfig/actions/runs/11490120376 |
|
Validated that these changes work in my own fork here: https://github.com/jepio/azure-osconfig/actions/runs/11501723726/job/32015144189 |
| @@ -5,7 +5,7 @@ ARG DEBIAN_FRONTEND=noninteractive | |||
| RUN apt-get -y update && apt-get -y install \ | |||
| gcc \ | |||
| git \ | |||
| cmake \ | |||
| cmake3 \ | |||
There was a problem hiding this comment.
https://github.com/Azure/azure-osconfig/actions/runs/11490120376/job/31980227024 disagrees with what you're saying:
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
CMake Error at CMakeLists.txt:9 (cmake_minimum_required):
CMake 3.2 or higher is required. You are running version 2.8.12.2
There was a problem hiding this comment.
Thanks but we do not believe this is the right way to address this. |
|
Thanks for jumping on this while it was night time here, investigating and proposing a fix. Much appreciated! The problem was fixed by re-adding back CMake 3 built from source as we do for the other distros. Luckily that was possible without having to readd other dependencies. This PR can be closed now. |
Description
The workflow for building 'OSConfig for MC' was changed to no longer build CMake v3.21.7 from sources, which led to using the default
cmakefrom the ubuntu 14.04 repository, which is v2.8. OSConfig doesn't allow building with cmake version less than v3.2. Switch to installing thecmake3package, which provides cmake v3.5, to meet the minimum cmake version requirement, and adjust the 'Build Azure OSConfig' step to account for that cmake version not supporting the--parallelargument.Checklist
mainbranch prior to this PR submission.mainbranch.