Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ubuntu 14.04 and 'OSConfig for MC' policy packages build workflow #775

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

AhmedBM
Copy link
Contributor

@AhmedBM AhmedBM commented Oct 22, 2024

Description

  • Added Ubuntu 14.04 Trusty build support (GCC 4.8) for building Machine Configuration policy packages
  • Added Publish (GitHub) workflow which doesn't publish just yet but currently builds the MC policy packages for Ubuntu 14.04 Trusty
  • Fixed Build Containers workflow to build the specified containers when the distro_list input is provided
  • Added a buildForMachineConfiguration input to the package-build.yml workflow to control whether to build the policy packages for MC or Debian/RPM packages
  • Renamed the publish.yml workflow to publish-pmc.yml to reflect the the new GItHub publishing variant with PMC

Checklist

  • I have read the contribution guidelines.
  • All unit tests are passing.
  • I have merged the latest main branch prior to this PR submission.
  • I submitted this PR against the main branch.

@AhmedBM AhmedBM requested a review from a team as a code owner October 22, 2024 20:04
Copy link

github-actions bot commented Oct 22, 2024

Test Results

 44 files  ±0   44 suites  ±0   39m 44s ⏱️ + 1m 16s
  4 tests ±0    4 ✅ ±0   0 💤 ±0  0 ❌ ±0 
176 runs  ±0  154 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit 5687bbf. ± Comparison against base commit 7c42863.

♻️ This comment has been updated with latest results.

@MariusNi MariusNi changed the title Added Ubuntu 14.04 and MC build workflow Adding Ubuntu 14.04 and 'OSConfig for MC' policy packages build workflow Oct 22, 2024
MariusNi
MariusNi previously approved these changes Oct 22, 2024
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi dismissed their stale review October 22, 2024 20:13

revoking review

@MariusNi
Copy link
Contributor

We need the CI also customized for this. Look out at this failure, for example (we are not building everything here):

-- Configuring incomplete, errors occurred!
See also "/azure-osconfig/build/CMakeFiles/CMakeOutput.log".

Could not find a package configuration file provided by
"azure_c_shared_utility" with any of the following names:

azure_c_shared_utilityConfig.cmake
azure_c_shared_utility-config.cmake

Add the installation prefix of "azure_c_shared_utility" to

devops/docker/ubuntu-14.04-amd64/Dockerfile Show resolved Hide resolved
.github/workflows/github.yml Outdated Show resolved Hide resolved
.github/workflows/publish-github.yml Show resolved Hide resolved
.github/workflows/package-publish-pmc.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi merged commit eca8cd4 into main Oct 22, 2024
153 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants