Skip to content

Commit

Permalink
fix persistSettings regression (#4450)
Browse files Browse the repository at this point in the history
* Fixing regression for persistSettings() which is trying to read values after an error.

* comment

* cl
  • Loading branch information
vhvb1989 authored Oct 17, 2024
1 parent 9070897 commit 0595f33
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
8 changes: 2 additions & 6 deletions cli/azd/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
# Release History

## 1.11.0-beta.1 (Unreleased)

### Features Added

### Breaking Changes
## 1.10.3 (2024-10-16)

### Bugs Fixed

### Other Changes
- [[4450]](https://github.com/Azure/azure-dev/pull/4450) fix `persistSettings` alpha feature.

## 1.10.2 (2024-10-08)

Expand Down
3 changes: 3 additions & 0 deletions cli/azd/pkg/containerapps/container_app.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ func (cas *containerAppService) persistSettings(
aca, err := cas.getContainerApp(ctx, subscriptionId, resourceGroupName, appName, options)
if err != nil {
log.Printf("failed getting current aca settings: %v. No settings will be persisted.", err)
// if the container app doesn't exist, there's nothing for us to update in the desired state,
// so we can just return the existing state as is.
return obj, nil
}

objConfig := config.NewConfig(obj)
Expand Down
2 changes: 1 addition & 1 deletion cli/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.11.0-beta.1
1.10.3

0 comments on commit 0595f33

Please sign in to comment.