Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: uncommenting item that reflects on the document links problem #658

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

felipementel
Copy link

I believe the issue in item #607 will be resolved with this commit.

@felipementel
Copy link
Author

Hi @waelkdouh, how are you?

Just like in my first comment on this pull request, I believe I have found the problem that is breaking the documentation links, and for that I originally created this pull request.

Today I updated the packages that need updating, and I have combined them in this same pull request.

If I think this could negatively affect the repository, I can cancel this request and create two separate ones.

I await your contact, thank you

@waelkdouh
Copy link
Contributor

Hi @felipementel could you elaborate a bit more on what you mean by it could pretend it could negatively affect this repository? I'm just trying to understand why you are suggesting creating two separate requests.

@felipementel
Copy link
Author

@waelkdouh
The reason would be the scope of the update.

There is a request for a documentation update, which refers to the problem
and another scope, which is the update of the nuget packages.

unfortunately, due to a "mistake" of mine, I combined everything in the same PR

@waelkdouh
Copy link
Contributor

Gotcha. No worries I will review and report back here accordingly. Thanks again for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants