-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Inspektor Gadget TCP and DNS traces #230
base: master
Are you sure you want to change the base?
Conversation
…e whether ig is supported
fix go linting issues
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 80.50% 81.11% +0.60%
==========================================
Files 14 16 +2
Lines 785 900 +115
==========================================
+ Hits 632 730 +98
- Misses 94 101 +7
- Partials 59 69 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you so much for this, Looks good to me. Let's definitely test this and fyi to @rzhang628 around this as well. Thank you ❤️ 🙏 sorry for the delay.
@@ -48,6 +48,6 @@ jobs: | |||
with: | |||
go-version: ${{ env.GO_VERSION }} | |||
- name: Go tests | |||
run: go test -v -race -coverprofile=coverage.out -covermode=atomic ./... | |||
run: sudo go test -v -race -coverprofile=coverage.out -covermode=atomic ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡Thank you for this. Archiving only: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#administrative-privileges - if anyone ponders sudo
use.
minor small question is: Why is sudo
needed?
"args": ["-test.v"], | ||
"showLog": true | ||
"showLog": true, | ||
// https://github.com/golang/vscode-go/blob/master/docs/debugging.md#debug-a-package-test-as-root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question please: 💡 What is the relevance of this .vscode/launch
file with this PR? aka if end-users editor is something else - say - vim
or anything else do we need some kind of small doc for fyi?
@peterbom please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This adds two collectors for Inspektor Gadget data: TCP and DNS traces (30 seconds each, with no namespace/node/pod filtering), building on initial integration work by @bravebeaver.
These collectors run in-process, meaning they invoke the Inspektor Gadget code directly, and do not install any other resources on the cluster.
This necessitated some changes to the way we launch tests (both locally from VS Code, and from the CI build). Because the tests are really E2E tests rather than unit tests, we wanted to actually run the Inspektor Gadget code from tests. And because running eBPF code requires elevated privileges, the tests now run as root.
cc: @Tatsinnit