Add feature filter usage tracing #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
mrm9084,
Eskibear,
juniwang,
zhenlan,
rossgrambo and
linglingye001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Collect telemetry for feature filter usage. (align with other providers)
Visible Change
Added integration test where a mock server is used to simulate response from App Config. The current mockAppConfigurationClientListConfigurationSettings method will not send http request @Eskibear. For the feature flag tracing scenario where we need to load feature flag in the first request, then parse the result and the feature flag related tracing will be included in the next request. So we have to create integration test here.
This is temporary solution. In the future, our test suite needs to be refactored