Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update proxy tests #5157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update proxy tests #5157

wants to merge 2 commits into from

Conversation

timmy-wright
Copy link
Contributor

@timmy-wright timmy-wright commented Oct 25, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • curl can use both the upper case and lower case versions of HTTP_PROXY, HTTPS_PROXY, and NO_PROXY
  • it prefers the lower case one if both are there.
  • We are setting both in /etc/environment (in cse_config.sh), but not both in this file.
  • So it makes sense to set both here.

Which issue(s) this PR fixes:

Requirements:

Special notes for your reviewer:

Release note:

Set both upper and lower case shell variables HTTP_PROXY, HTTPS_PROXY, and NO_PROXY during bootstrapping.

@@ -204,17 +204,22 @@ func getOutBoundCmd(nbc *datamodel.NodeBootstrappingConfiguration, cloudSpecConf

func getProxyVariables(nbc *datamodel.NodeBootstrappingConfiguration) string {
// only use https proxy, if user doesn't specify httpsProxy we autofill it with value from httpProxy.
// note that we set both upper case and lower case varients. curl can use both, but has a preference for the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor typo:

Suggested change
// note that we set both upper case and lower case varients. curl can use both, but has a preference for the
// note that we set both upper case and lower case variants. curl can use both, but has a preference for the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants