fix: set pipeline variables even if build fails #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachary-bailey
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1 and
timmy-wright
as code owners
djsly
approved these changes
Oct 17, 2024
cameronmeissner
approved these changes
Oct 17, 2024
zachary-bailey
force-pushed
the
zb/alwaysRunSetPipelineVariablesStep
branch
from
05ad779
to
3d481b6
Compare
zachary-bailey
force-pushed
the
zb/alwaysRunSetPipelineVariablesStep
branch
from
3d481b6
to
5f18635
Compare
zachary-bailey
force-pushed
the
zb/alwaysRunSetPipelineVariablesStep
branch
from
5f18635
to
db60107
Compare
zachary-bailey
force-pushed
the
zb/alwaysRunSetPipelineVariablesStep
branch
from
db60107
to
18f1210
Compare
zachary-bailey
force-pushed
the
zb/alwaysRunSetPipelineVariablesStep
branch
from
18f1210
to
bf34424
Compare
zachary-bailey
force-pushed
the
zb/alwaysRunSetPipelineVariablesStep
branch
from
bf34424
to
080333c
Compare
zachary-bailey
force-pushed
the
zb/alwaysRunSetPipelineVariablesStep
branch
from
080333c
to
5173e6c
Compare
added 2 commits
October 24, 2024 09:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR changes the logic in our pipeline template to always run the
Set Pipeline Variablesstep, even if the build fails. This helps ensure thatcleanup.shwill always be run if the packer build actually started and povisioned resources.Which issue(s) this PR fixes:
Set Pipeline Variableswould not run if the build failed.Requirements: