Remove Testdata under sourced control #5004
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsly
changed the title
Pull Request Test Coverage Report for Build 11077857457Details
💛 - Coveralls |
| @@ -99,13 +106,6 @@ generate: bootstrap | |||
| ./hack/tools/bin/cue export ./schemas/manifest.cue > ./parts/linux/cloud-init/artifacts/manifest.json | |||
There was a problem hiding this comment.
should we make a validate-manifest as well?
personally I actually think we can remove all references to manifest.json from everywhere except the provisioning scripts themselves, since we no longer actually use it when building VHDs. though we'll need to keep using it as a fallback in the provisioning scripts for cases where newer CSE/customdata is running on older VHDs
There was a problem hiding this comment.
I think it's used by NVIDIA?GPU , need to check with Ganesh. My goal was to get ride of those line.
| @@ -19,6 +19,10 @@ test/e2e/kubernetes/junit.xml | |||
| _logs/ | |||
| *.swp | |||
|
|
|||
| # test data | |||
| pkg/agent/testdata/ | |||
There was a problem hiding this comment.
still not sure we can just do this, will discuss offline
djsly
force-pushed
the
dsly/remove-testdata
branch
from
40b689e
to
0aa86f6
Compare
djsly
force-pushed
the
dsly/remove-testdata
branch
from
0de6898
to
295af70
Compare
djsly
force-pushed
the
dsly/remove-testdata
branch
from
32f5a9b
to
6ddd53a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert script from sh to go, update makefile logic, adding testdata to gitignore
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: