-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Testdata under sourced control #5004
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 11077857457Details
💛 - Coveralls |
@@ -99,13 +106,6 @@ generate: bootstrap | |||
./hack/tools/bin/cue export ./schemas/manifest.cue > ./parts/linux/cloud-init/artifacts/manifest.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make a validate-manifest
as well?
personally I actually think we can remove all references to manifest.json from everywhere except the provisioning scripts themselves, since we no longer actually use it when building VHDs. though we'll need to keep using it as a fallback in the provisioning scripts for cases where newer CSE/customdata is running on older VHDs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's used by NVIDIA?GPU , need to check with Ganesh. My goal was to get ride of those line.
@@ -19,6 +19,10 @@ test/e2e/kubernetes/junit.xml | |||
_logs/ | |||
*.swp | |||
|
|||
# test data | |||
pkg/agent/testdata/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still not sure we can just do this, will discuss offline
40b689e
to
0aa86f6
Compare
0de6898
to
295af70
Compare
32f5a9b
to
6ddd53a
Compare
convert script from sh to go, update makefile logic, adding testdata to gitignore
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: