Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Strings #25

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Shared Strings #25

wants to merge 10 commits into from

Conversation

fschetterer
Copy link

Hi you may be interested in merging some of these changes, in particular the Shared Strings for XLSX.

Changes to compile In Berlin 10.1.2 without Warnings.

Exported 550k records to XLMX in 1:42
…nerates DCUs in .\lib\$(ProductVersion)\$(Config)\$(Platform)

Never tried to install it.
…some of that because once I changed my CodeInsight began working again.

2 - Added SharedStrings support at least for XlSX Export, works but needs a good shake down.
…tring for XLSX only.

Fully Documented Inline
Copy link
Owner

@Avemey Avemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks D7 compability. inline keyword starts with D2005.
Use ifdef

@fschetterer
Copy link
Author

fschetterer commented Jun 17, 2018

Breaks D7 compability

Right, I made these changes for Berlin and up. I don't remember if Helpers where in D7 either, but its one spot so I'll change that in a minute.

But that wont help since the code uses other helper methods, take what you want I don't have any of the 'last century' compilers installed :)

And I really appreciate you making this tool available because the speed rocks.

@Avemey
Copy link
Owner

Avemey commented Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants