Add command line options for run_browser and dark_mode Gui.run() parameters #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabienLelaquais
added
📈 Improvement
FabienLelaquais
requested review from
namnguyen20999,
dinhlongviolin1 and
FredLL-Avaiga
FabienLelaquais
changed the title
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
FredLL-Avaiga
approved these changes
Oct 22, 2024
| "action": "store_true", | ||
| }, | ||
| "--no-run-browser": { | ||
| "dest": "taipy_no_run_browser", |
There was a problem hiding this comment.
can we not use the same dest with action: store_false ?
There was a problem hiding this comment.
I agree. I chose to use the same pattern as for other options for homogeneity.
But I had the same question, with the same answer. This could be simplified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the --run-browser, --no-run-browser, --dark-mode, and --light-mode CLI options.