Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increased code efficiency of taipyRendered #2044

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

divyamprabhudessai
Copy link

  1. Organized Imports: Grouped third-party, project, and utility imports for clarity.
  2. setStyle Refactoring: Simplified the function to make it more readable and efficient.
  3. computePath Function: Encapsulated path computation logic in a separate function for clarity.
  4. Early Returns in useEffect: Used an early return to avoid deeply nested conditions.
  5. Moved Head Elements Creation Outside JSX: Prepared head elements before returning the JSX to optimize rendering.

Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see your point and the overall added value of your PR.
Every code could be improved but unless you create tests that shows that everything works exactly as before, you're adding a possibility of bugs in a central part of the product.

@@ -1,27 +1,14 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad start

@FredLL-Avaiga
Copy link
Member

Are you still working on this PR @divyamprabhudessai ?
If you are, please resolve the conflicts, update your branch and answer the questions
If you are not, please close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants