#1801 Added close a specific notification feature

[AdeshGhadage]

This pull request addresses issue #1801

Hello Maintainers,

Could you please review my code? I would appreciate any suggestions or feedback you might have.

[AdeshGhadage]

@jrobinAV can you review my pr please?

[FlorianJacta]

I have put @FabienLelaquais and @FredLL-Avaiga as reviewers of this PR.

[FredLL-Avaiga]

Waiting eagerly for the frontend part of it

[FabienLelaquais]

Nice

[FredLL-Avaiga]

waiting for the frontend :-D

[AdeshGhadage]

@quest-bot loot #1801

[quest-bot]

Quest PR submitted!

@AdeshGhadage, you are attempting to solve the issue and loot this Quest. Will you be successful?

---

Questions? Check out the docs.

[FredLL-Avaiga]

Looks very good, tx @AdeshGhadage

• a few changes
• some tests

[FredLL-Avaiga]

please update your branch

[FredLL-Avaiga]

any question ?

[AdeshGhadage]

any question ?

is my pr correct? any suggestion or changed i have missed ?

[FredLL-Avaiga]

A few comments

• Would be nice to have an example that shows how to get the returned notification_id and delete the notification (/doc/gui/examples)

[FredLL-Avaiga]

thanks to makes the resolved discussions as resolved and to update the branch

[FredLL-Avaiga]

looks almost good
Just needs a few tests

[FredLL-Avaiga]

Very good
Now we need some tests:

• backend to check that the ws payload looks OK
• frontend around the reducer and Alerts (fix the ones that are broken + ?)

[FredLL-Avaiga]

Branch updated

[FredLL-Avaiga]

an old test is now failing, can you fix it ?
const action = { type: Types.DeleteAlert };
644 | const newState = taipyReducer(initialState, action);
> 645 | expect(newState.alerts).toEqual([
| ^
646 | {
647 | message: "alert2",
648 | atype: "type2",

[FredLL-Avaiga]

PS: I've updated your branch

[AdeshGhadage]

Very good Now we need some tests:

• backend to check that the ws payload looks OK
• frontend around the reducer and Alerts (fix the ones that are broken + ?)

why its giving empty array as during test? can help resolve this issue?

[FredLL-Avaiga]

Very good Now we need some tests:

• backend to check that the ws payload looks OK
• frontend around the reducer and Alerts (fix the ones that are broken + ?)

why its giving empty array as during test? can help resolve this issue?

Because there's no id passed in the deleteAction so every element of the array is filtered out
That's why you need to change that test to provide a valid id to the delete action

[AdeshGhadage]

there is some issue with nanoid call i tried to mock the nanoid library by using

jest.mock('nanoid', () => ({
   nanoid: jest.fn(() => 'mockedId'),
}));

but still not worked so i put random string

[FredLL-Avaiga]

Excellent work
Tx @AdeshGhadage

[FredLL-Avaiga]

Can you merge this @jrobinAV ?