Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AlertComponent for displaying alerts in the GUI #1975
base: develop
Are you sure you want to change the base?
Add AlertComponent for displaying alerts in the GUI #1975
Changes from 8 commits
a4c1f02
31f9bc2
7b3d3d7
965deb7
97bbda4
5d7b543
1654d62
af84cfb
3b6fd8a
2ed97c0
1cff75e
c50e8ca
55ace5a
e3023e1
80d3621
67ed55d
c69b596
23bb22b
ce58645
73aabd8
f053daa
d4fec0e
e69a0ec
5346893
5f6e40f
9ead544
7582bbb
2633fd3
474cddf
0bf9b5c
9becf2f
1346fe7
0119c35
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be declared as
message?: string;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the nearest possible future, we will have to rename 'Notification' to 'Alert' for homogeneity (although programmers don't really care).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FabienLelaquais thanks for your review, but
Alert.tsx
already exists.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need this 'variant' property, although it simplifies styling.
I mean no other element has that kind of styling=-dedicated property.
We will discuss that.