Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): fetch articles only when filter changes #621

Merged
merged 1 commit into from
Feb 18, 2024
Merged

fix(ui): fetch articles only when filter changes #621

merged 1 commit into from
Feb 18, 2024

Conversation

lazzzis
Copy link
Contributor

@lazzzis lazzzis commented Feb 17, 2024

  1. remove fetchArticles since changeFilter internally invokes that
  2. call changeFilter only when filter changes

Before

Screen_recording_20240216_223930.mp4

After

Screen_recording_20240216_223826.mp4

@JunkFood02
Copy link
Collaborator

thx!

@JunkFood02 JunkFood02 changed the title fix(ui): page flickers when tapping bottom bar fix(ui): fetch articles only when filter changes Feb 18, 2024
@JunkFood02 JunkFood02 merged commit 6b4b215 into Ashinch:main Feb 18, 2024
1 check passed
@lazzzis lazzzis deleted the fix-flickr branch February 19, 2024 06:27
@Ashinch Ashinch added this to the 0.9.13 milestone Feb 20, 2024
This was referenced Jun 4, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lazzzis @JunkFood02 @Ashinch