refactor(ui): redesign swipe mark as read for article item #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps this issue could provide some information |
Yes, the functional style of Compose makes many things private, If want to break it, need to make a copy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we don't have the option to mark as unread by swiping left, so
SwipeableArticleItemis unnecessary when the article has been read.(Mainly because I haven't found a way to increase the swipe friction, and the default friction factor makes it easy for users to accidentally trigger it.)
In order to give
SwipeableArticleItemthe features of Material You, I have redesigned it. The new design may not be very friendly to languages with long characters.