Make the item swipe design more universal #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #455, which implemented a swipe to mark articles as read. In the original pull request, we get a gray tint over the article item, but I found that this did not look good. I made it apply to the current theme, which looks universal and clean.
It's nice to finally have it implemented, but we need to limit it to 'unread' flow only, and make the article list reload after a small delay (say 20-30 ms) to make it smoother, since we don't have the list animation after a swipe that refreshes right after a gesture dismiss. I hope it will get your attention and we will make it work as smooth as expected.
Cheers, and thanks @boun for such a great PR! Can't wait for a release :D