Ash framework 3 compatibility #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash version 3 stopped using Ash.ErrorKind
Ash framework 3 compatibility
When attribute value is not nil, it can still have validation errors
Check errors for non-nil attributes
|
Thanks! |
ArthurClemens
added a commit
that referenced
this pull request
Aug 14, 2024
* Patch version * Ash framework 3 compatibility (#187) * Ash framework 3 compatibility Ash version 3 stopped using Ash.ErrorKind * Check errors for non-nil attributes When attribute value is not nil, it can still have validation errors * btn-octicon: remove whitespace introduced by the default display: inline-block * Set up quality checks * Remove icon build module from build * Add CI checks * Restore logic for expanded * chore(deps): update dependency tsx to v4.17.0 (#185) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.14.15 (#186) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Co-authored-by: Andrey Demenev <andrey@1crm.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
I will probably revisit this later. In AshPhoenix, AshPhoenix.FormData.Error protocol is used for more user-friendly error reporting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ash version 3 stopped using Ash.ErrorKind