Lock cacheLock when switching to last custom theme

Arkhist · Jul 30, 2021 · a7427ff · a7427ff
1 parent 60db1da
commit a7427ff
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/PathfinderAPI/BaseGameFixes/Performance/ThemeCaching.cs b/PathfinderAPI/BaseGameFixes/Performance/ThemeCaching.cs
@@ -131,14 +131,18 @@ internal static bool SwitchToLastCustomTheme(object osObject, OSTheme theme)
         {
             if (theme == OSTheme.Custom)
             {
-                // just dont question it
-                var lastTheme = CachedThemes.BackingListHead?.Value;
-                if (lastTheme != null)
+                lock (cacheLock)
                 {
-                    if (!lastTheme.Loaded)
-                        lastTheme.Load(true);
-                    lastTheme.ApplyTo((OS)osObject);
+                    // just dont question it
+                    var lastTheme = CachedThemes.BackingListHead?.Value;
+                    if (lastTheme != null)
+                    {
+                        if (!lastTheme.Loaded)
+                            lastTheme.Load(true);
+                        lastTheme.ApplyTo((OS) osObject);
+                    }
                 }
+
                 return false;
             }