Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flutter): date picker improvements #6582

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(flutter): date picker improvements #6582

wants to merge 11 commits into from
+2,944 −2,167

Conversation

richardshiue
Copy link
Collaborator

@richardshiue richardshiue commented Oct 19, 2024 •
edited
Loading

Screenshot 2024-10-19 at 5 37 53 PM

User-facing changes:

  • enter date and time using keyboard, support parsing in current locale
  • improve look of the date picker header, no longer look squished on Linux and WIndows platforms
  • i18n for database date cells
  • focus traversal and submit on leave

Developer-facing changes:

  • clean up parameter and callbacks to AppFlowyDatePicker and MobileAppFlowyDatePicker widgets.
  • internal states for these widgets are better encapsulated and managed within the widget, ensuring same behavior across different places where the widget is used. No longer worry about focusedDay, selectedDay, startDay, endDay parameters, but just pass in dateTime, endDateTime, includeTime, isRange and desired onChanged callbacks.

resolves #4617
resolves #4309
resolves #3496
resolves #3027
resolves #2441
resolves #1887

Feature Preview

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@richardshiue
feat(flutter): improve date picker
82ba13f 
- visual improvements to the date picker header
- remove medium font weight on the reminder button
- support i18n date formatting
- support parsing date and time from keyboard input
- support focus traversal and submit-on-leave
- code cleanup
@richardshiue
test: add widget tests
e51ff10
@richardshiue
test: add bloc test
9185d14
@richardshiue
test: adjust rust-lib tests
a812e4d
@richardshiue richardshiue changed the title Feat/date parse feat(flutter): date picker improvements Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v0.7.3
Projects
None yet
Milestone
No milestone
1 participant
@richardshiue