Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turn into multiple lines #6558

Merged
merged 11 commits into from
Oct 16, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Oct 16, 2024

Feature Preview

showcase.mp4
  • select multiple lines with block selection style.
  • turn into multiple lines
  • a. take care of the blocks that are not allowed to have children, such as headings, quotes, and callouts, when turning them into...
    • nested list -> heading
    • nested list -> callout
    • nested list -> quote
  • b. Only transform nodes at the same level into another block type (not including their children, if they have any)
    • multiple nested list -> another block type
  • c. revert back
    • block -> block -> undo -> redo
    • nested list -> block -> undo -> redo
    • nested list with children - > block -> undo -> redo
  • known issues
    • update selection after turning block into another block
    • sometimes, block selection doesn't work
  • unit tests
    • a.
    • b.
    • c.
  • integration test
    • turn into multi lines

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@LucasXu0 LucasXu0 marked this pull request as draft October 16, 2024 09:16
@LucasXu0 LucasXu0 marked this pull request as ready for review October 16, 2024 09:48
@LucasXu0 LucasXu0 merged commit a8bcab7 into AppFlowy-IO:main Oct 16, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant