feat: calculations #4473
Merged
feat: calculations #4473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appflowy
reviewed
Jan 24, 2024
| ) -> FlowyResult<()> { | ||
| self | ||
| .delegate | ||
| .remove_calculation(¶ms.view_id, ¶ms.calculation_id); |
There was a problem hiding this comment.
how about returning the Calculation after calling the remove_calculation
appflowy
reviewed
Jan 24, 2024
frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs
Outdated
Show resolved
Hide resolved
appflowy
reviewed
Jan 24, 2024
frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs
Outdated
Show resolved
Hide resolved
appflowy
reviewed
Jan 24, 2024
frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs
Outdated
Show resolved
Hide resolved
appflowy
reviewed
Jan 25, 2024
frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs
Outdated
Show resolved
Hide resolved
appflowy
reviewed
Jan 25, 2024
frontend/rust-lib/flowy-database2/src/services/calculations/entities.rs
Outdated
Show resolved
Hide resolved
appflowy
reviewed
Jan 25, 2024
appflowy
reviewed
Jan 25, 2024
Xazin
force-pushed
the
feat/calculation-controller
branch
from
8b18e18
to
7c20f14
Compare
LucasXu0
pushed a commit
to LucasXu0/AppFlowy
that referenced
this pull request
Feb 18, 2024
* feat: initial calculation controller * fix: entities * feat: calculations * fix: review comments and support floats * fix: abstract business logic into calculations service * fix: clean calculation entities after merge * feat: react to changes to row/cell/field_type * chore: changes after merging main * feat: handle delete field * test: add grid calculations tests * fix: add validation + format numbers * refactor: get cell number * chore: bump collab * chore: fix clippy * chore: update docs * chore: update docs * chore: fmt * chore: fix flutter * chore: collab rev * fix: cleanup and hover to show * fix: localization * test: add basic rust test * fix: clippy * fix: support updating calculation on duplicate row --------- Co-authored-by: nathan <nathan@appflowy.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: AppFlowy-IO/AppFlowy-Collab#152
Feature Preview
PR Checklist