Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to accept epoch when moment is initialized #18

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

artknight
Copy link
Contributor

No description provided.

@artknight
Copy link
Contributor Author

@atuttle do you think you could merge soon?

@atuttle
Copy link
Member

atuttle commented Jun 23, 2016

I spent some time working on it last weekend. I'm eager to get it in but I need to get all of the tests passing first.

@artknight
Copy link
Contributor Author

Awesome, Thanks!

-- Arthur

On Thu, Jun 23, 2016 at 9:46 AM, Adam Tuttle notifications@github.com
wrote:

I spent some time working on it last weekend. I'm eager to get it in but I
need to get all of the tests passing first.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#18 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAJoQs0hIWYU1fK95pYk04ARrG69HARuks5qOo4ngaJpZM4IyeWe
.

@artknight
Copy link
Contributor Author

any luck?

@atuttle
Copy link
Member

atuttle commented Jul 8, 2016

Not yet. Been underwater between work and freelance stuff.

I forget exactly where I left off, but I believe I made some test additions & changes, and also may have made some modifications to your changes. If I get a chance I'd like to push a branch with all of that in it so you could pick up where I left off. Sorry for being the bottleneck!

@artknight
Copy link
Contributor Author

artknight commented Jul 8, 2016

Hey if you need another maintainer I could find time here and there to put
in. Just a thought. :-)

-- Arthur

On Fri, Jul 8, 2016 at 3:54 PM, Adam Tuttle notifications@github.com
wrote:

Not yet. Been underwater between work and freelance stuff.

I forget exactly where I left off, but I believe I made some test
additions & changes, and also may have made some modifications to your
changes. If I get a chance I'd like to push a branch with all of that in it
so you could pick up where I left off. Sorry for being the bottleneck!


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#18 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAJoQupH0sA-Wf3otBkWoMsaVnWiHpIWks5qTqsEgaJpZM4IyeWe
.

@atuttle
Copy link
Member

atuttle commented Jul 8, 2016

Thanks! I'll see if I can get that branch up with tests asap.

@artknight
Copy link
Contributor Author

@atuttle how is it going with this one?

@artknight
Copy link
Contributor Author

@atuttle if you need help getting PRs in please let me know! ( It should not take months to get a PR merged )

@atuttle
Copy link
Member

atuttle commented Jan 4, 2017

It should not take months to get a PR merged

Generally it doesn't. Your change is a good idea, but the implementation broke just as much, if not more, than it fixed. ;)

Sorry, I just haven't had time to come back to this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants