Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Software Cursor, closes #1090 #1342

Merged
merged 4 commits into from
Mar 24, 2024
Merged

feat: Software Cursor, closes #1090 #1342

merged 4 commits into from
Mar 24, 2024

Conversation

alexmoore04
Copy link
Contributor

@alexmoore04 alexmoore04 commented Feb 12, 2024

adds virtual cursor
@Leo-Waters
@popsx0x

adds virtual cursor

Co-Authored-By: popsx0x <125997098+popsx0x@users.noreply.github.com>
Co-Authored-By: li0nleo <41073073+li0nleo@users.noreply.github.com>
@alexmoore04 alexmoore04 changed the title feat: Software Cursor, closes feat: Software Cursor, closes #1090 Feb 12, 2024
Copied over from other project and fixed to work without multiplayer
added new UI bars
@AlmasB
Copy link
Owner

AlmasB commented Feb 20, 2024

Thanks, please can you check why the PR is failing checks

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 59.54%. Comparing base (ed749b8) to head (6b7a50d).
Report is 13 commits behind head on dev.

Files Patch % Lines
...c/main/java/com/almasb/fxgl/ui/SoftwareCursor.java 0.00% 23 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1342      +/-   ##
============================================
+ Coverage     59.48%   59.54%   +0.06%     
- Complexity     2980     3005      +25     
============================================
  Files           312      317       +5     
  Lines         15331    15396      +65     
  Branches       1561     1562       +1     
============================================
+ Hits           9119     9167      +48     
- Misses         5691     5709      +18     
+ Partials        521      520       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@AlmasB AlmasB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the base implementation

@AlmasB AlmasB merged commit 728d582 into AlmasB:dev Mar 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants