Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 253 upgrade schema #255

Merged
merged 10 commits into from
Sep 7, 2024
Merged

Feat 253 upgrade schema #255

merged 10 commits into from
Sep 7, 2024

Conversation

mekhlakapoor
Copy link
Contributor

@mekhlakapoor mekhlakapoor commented Sep 3, 2024 •
edited
Loading

Closes #253

This PR:

  • Upgrades pinned aind-metadata-mapper version to pull from dev (has aind-data-schemav1.0)
  • Fixes imports
  • Fixes sharepoint raw jsons to valid NSBList/LASList objects (specificially, enum fields)
  • No longer handles edge case where value in an enum field is not a member of enum (checked nsb2019.json and nsb2023.json and found no real cases of this)
  • Comments out deprecated OptionalEnumMeta call method. Will fix this/remove this in a future ticket
  • Returns input_name directly for funder info (from_abbreviation was returning None; we can also opt to just return None in that case)

@mekhlakapoor mekhlakapoor marked this pull request as draft September 3, 2024 23:35
@mekhlakapoor mekhlakapoor requested review from jtyoung84 and removed request for jtyoung84 September 4, 2024 22:47
@mekhlakapoor mekhlakapoor marked this pull request as ready for review September 4, 2024 22:59
@jtyoung84 jtyoung84 merged commit c8e6b5b into main Sep 7, 2024
2 checks passed
@jtyoung84 jtyoung84 deleted the feat-253-upgrade-schema branch September 7, 2024 18:13
mekhlakapoor added a commit that referenced this pull request Oct 25, 2024
@mekhlakapoor @jtyoung84
Feat 253 upgrade schema (#255)
ffe028b 
* fix: nsb2023, nsb2019, las2020, labtracks, smartsheet
* fix: comments out OptionalEnumMeta
* feat: adds upper bound to pydantic
* feat: updates aind-metadata-mapper to v0.17.0, which install aind-data-schema v1.0.0
---------

Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtyoung84 jtyoung84 jtyoung84 approved these changes

@dyf dyf Awaiting requested review from dyf

@saskiad saskiad Awaiting requested review from saskiad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to use aind-data-schema v1.0
2 participants
@mekhlakapoor @jtyoung84