Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 239 LAS surgeries #241

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Feat 239 LAS surgeries #241

merged 7 commits into from
Jun 26, 2024

Conversation

mekhlakapoor
Copy link
Contributor

@mekhlakapoor mekhlakapoor commented Jun 25, 2024

closes #239

This PR:

  • Updates sharepoint settings to include las list
  • Adds parsed schema models and mappings for LAS 2020 list
  • Creates basic Surgery model from las info
  • Adds LAS sharepoint response to procedures endpoint

We'll need to re-deploy the metadata-service with credentials for a new principal account.
*Note: fetching data from this list is a bit slower than the rest, takes about 30 seconds

@mekhlakapoor mekhlakapoor marked this pull request as draft June 25, 2024 02:24
@mekhlakapoor mekhlakapoor marked this pull request as ready for review June 25, 2024 23:11
)
nsb_2019_list: str = Field(
default="SWR 2019-2022",
title="NSB 2019 List",
description="List name for 2019 database.",
description="List name for Neurosurgery & Behavior 2019 database.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to avoid special characters like ampersands

Copy link
Contributor

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from my perspective

@jtyoung84 jtyoung84 merged commit 219bf20 into main Jun 26, 2024
2 checks passed
@jtyoung84 jtyoung84 deleted the feat-239-NSP branch June 26, 2024 22:15
mekhlakapoor added a commit that referenced this pull request Oct 25, 2024
* auto-generated schemas and mappings

* nsp to las, basic mappings (WIP)

* updates sharepoint client

* adds las sharepoint response to server

---------

Co-authored-by: jtyoung84 <104453205+jtyoung84@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add endpoint to map from LAS sharepoint NSP
3 participants