Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

76 add expected metadata files split by modality #83

Merged
merged 12 commits into from
Sep 25, 2024

Conversation

dbirman
Copy link
Member

@dbirman dbirman commented Sep 25, 2024

This PR adds a new class ExpectedFiles that tracks whether modalities are expected to have each of the metadata file types. Files can be required, optional, or ignored.

>>> from aind_data_schema_models.modalities import ExpectedFiles
>>> ExpectedFiles.ECEPHYS.subject
<FileRequirement.REQUIRED: 1>
>>> ExpectedFiles.ECEPHYS.quality_control
<FileRequirement.OPTIONAL: 0>

This also required changing field_handlers to allow passing the field key.

@dbirman dbirman linked an issue Sep 25, 2024 that may be closed by this pull request
@dbirman dbirman requested review from dyf and saskiad September 25, 2024 04:12
Copy link
Collaborator

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wanting a different label than ignored....

Copy link
Collaborator

@saskiad saskiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like excluded! thanks!

@saskiad saskiad merged commit 419163c into main Sep 25, 2024
4 checks passed
@saskiad saskiad deleted the 76-add-expected-metadata-files-split-by-modality branch September 25, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expected metadata files split by modality
2 participants