-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
76 add expected metadata files split by modality #83
Merged
saskiad
merged 12 commits into
main
from
76-add-expected-metadata-files-split-by-modality
Sep 25, 2024
Merged
76 add expected metadata files split by modality #83
saskiad
merged 12 commits into
main
from
76-add-expected-metadata-files-split-by-modality
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 = required, 0 = optional, -1 = never present
saskiad
reviewed
Sep 25, 2024
saskiad
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wanting a different label than ignored....
saskiad
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like excluded! thanks!
saskiad
deleted the
76-add-expected-metadata-files-split-by-modality
branch
September 25, 2024 04:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new class ExpectedFiles that tracks whether modalities are expected to have each of the metadata file types. Files can be required, optional, or ignored.
This also required changing field_handlers to allow passing the field key.