Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix get_spike_matrix func #364

Open
rcpeene opened this issue Mar 19, 2024 · 1 comment
Open

fix get_spike_matrix func #364

rcpeene opened this issue Mar 19, 2024 · 1 comment
Assignees
@jeromelecoq

Comments

@rcpeene
Copy link
Collaborator

rcpeene commented Mar 19, 2024 •
edited
Loading

in issue #350 , I changed the usage get_spike_matrix function in all files. This broke something. Specifically I believe it results from a rounding error when generating the bin edges versus calculating the diffs from the bins afterward. Should fix. May need to return to passing in bin_sz to the function for proper usage.
rcpeene added a commit that referenced this issue Mar 19, 2024
@rcpeene
fix error in previous commit as per issue #364
62bd5b0
@jeromelecoq
Copy link
Collaborator

Carter will make a PR to review this function by Jerome

@jeromelecoq jeromelecoq assigned jeromelecoq and unassigned rcpeene Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeromelecoq jeromelecoq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromelecoq @rcpeene