Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::swap on two pointers instead of static arrays of pointers for ping-ponging between two live volumes. #299

Open
3 tasks
Algomorph opened this issue Nov 24, 2020 · 0 comments
Open
3 tasks

Use std::swap on two pointers instead of static arrays of pointers for ping-ponging between two live volumes. #299

Algomorph opened this issue Nov 24, 2020 · 0 comments
Labels
ease-of-maintenance Resolving this issue would significantly improve ease of maintenance and future development.

Comments

@Algomorph
Copy link
Owner

The code is unnecessarily confusing due to the integer indexing of live volumes as "source" and "live" and then swapping the two indices. Use two pointers directly, and swap the two volumes.

  • Method signatures of LevelSetAlignment engine.
  • Allocations in DynamicSceneVoxelEngine.
  • GenericMultiIterationAlignmentSubtest in LevelSetAlignmentTestUtilities.tpp
@Algomorph Algomorph added the ease-of-maintenance Resolving this issue would significantly improve ease of maintenance and future development. label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ease-of-maintenance Resolving this issue would significantly improve ease of maintenance and future development.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Algomorph