Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for combined packages on windows #1759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cfxegbert
Copy link
Contributor

@cfxegbert cfxegbert commented May 17, 2024

Fixes #1758

See bug #1758 for detail explanation

fix: check for None when normalizing paths
@cfxegbert cfxegbert requested a review from a team as a code owner May 17, 2024 20:14
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.39%. Comparing base (a13f7bb) to head (5c6f6bd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1759      +/-   ##
==========================================
- Coverage   58.41%   58.39%   -0.02%     
==========================================
  Files         126      126              
  Lines       17163    17163              
  Branches     3506     3506              
==========================================
- Hits        10025    10023       -2     
- Misses       6473     6474       +1     
- Partials      665      666       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfxegbert
Copy link
Contributor Author

cfxegbert commented Jul 25, 2024

Can this be reviewed for inclusion in the next rez release? I currently have to patch rez when building for windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combined packages (multi packages) fail on windows
1 participant