Skip to content

Commit

Permalink
Merge pull request #375 from ARCANEDEV/php-8-support
Browse files Browse the repository at this point in the history
Adding PHP 8.0 support
  • Loading branch information
arcanedev-maroc authored Nov 28, 2020
2 parents 71ed2ab + a5bd6c1 commit 0a92dcf
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [7.3, 7.4]
php: [7.3, 7.4, 8.0]
dependency-version: [prefer-lowest, prefer-stable]

name: PHP ${{ matrix.php }} - ${{ matrix.dependency-version }}
Expand All @@ -30,9 +30,10 @@ jobs:
php-version: ${{ matrix.php }}
extensions: curl, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, iconv
coverage: xdebug
tools: composer:v2

- name: Install dependencies
run: composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-suggest
run: composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction

- name: Execute tests
run: |
Expand Down
2 changes: 1 addition & 1 deletion .scrutinizer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ checks:
tools:
external_code_coverage:
timeout: 600
runs: 4
runs: 6
php_code_sniffer:
enabled: true
config:
Expand Down
7 changes: 4 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@
"type": "library",
"license": "MIT",
"require": {
"php": "^7.3",
"php": "^7.3|^8.0",
"ext-json": "*",
"arcanedev/support": "^8.0",
"psr/log": "^1.1"
},
"require-dev": {
"orchestra/testbench": "^6.0",
"phpunit/phpunit": "^9.3"
"mockery/mockery": "^1.4.2",
"orchestra/testbench": "^6.4",
"phpunit/phpunit": "^9.3.3"
},
"autoload": {
"psr-4": {
Expand Down
4 changes: 1 addition & 3 deletions tests/Commands/ClearCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,9 @@ protected function tearDown(): void
/** @test */
public function it_can_delete_all_log_files(): void
{
static::assertEquals(0, $this->logViewer->count());

static::createDummyLog(date('Y-m-d'), 'logs-to-clear');

static::assertEquals(1, $this->logViewer->count());
static::assertGreaterThanOrEqual(1, $this->logViewer->count());

$this->artisan('log-viewer:clear')
->expectsQuestion('This will delete all the log files, Do you wish to continue?', 'yes')
Expand Down

0 comments on commit 0a92dcf

Please sign in to comment.